Continue to clean up the amplc_pci230 driver code and remove the legacy attach mechanism, since it isn't very useful for this driver (see PATCH 05/28). 01) staging: comedi: amplc_pci230: update MODULE_DESCRIPTION() 02) staging: comedi: amplc_pci230: don't use multiple blank lines 03) staging: comedi: amplc_pci230: remove some unnecessary parentheses 04) staging: comedi: amplc_pci230: collapse some 'else { if' chains 05) staging: comedi: amplc_pci230: remove "legacy" attach mechanism 06) staging: comedi: amplc_pci230: no need to manipulate PCI ref count 07) staging: comedi: amplc_pci230: set detach handler to comedi_pci_detach() 08) staging: comedi: amplc_pci230: absorb pci230_attach_common() 09) staging: comedi: amplc_pci230: no need to comedi_set_hw_dev() here 10) staging: comedi: amplc_pci230: absorb pci230_alloc_private() 11) staging: comedi: amplc_pci230: remove ai_chans member 12) staging: comedi: amplc_pci230: remove ao_chans member 13) staging: comedi: amplc_pci230: shrink struct pci230_board 14) staging: comedi: amplc_pci230: simplify pci230_ao_mangle_datum() 15) staging: comedi: amplc_pci230: simplify pci230_ai_read() 16) staging: comedi: amplc_pci230: remove 'inline' 17) staging: comedi: amplc_pci230: rename pci230_ai_rinsn() 18) staging: comedi: amplc_pci230: add `pci230_` prefix to functions 19) staging: comedi: amplc_pci230: use comedi_range_is_bipolar() 20) staging: comedi: amplc_pci230: make `intr_running` a bitfield 21) staging: comedi: amplc_pci230: replace `state` member with bitfields 22) staging: comedi: amplc_pci230: rewrite shared resource handling 23) staging: comedi: amplc_pci230: reduce indentation in pci230_ao_inttrig_scan_begin() 24) staging: comedi: amplc_pci230: reduce indentation in pci230_ao_start() 25) staging: comedi: amplc_pci230: reduce indentation in pci230_ai_inttrig_convert() 26) staging: comedi: amplc_pci230: reduce indentation in pci230_ai_start() 27) staging: comedi: amplc_pci230: change pci230_handle_ao_fifo() return type 28) staging: comedi: amplc_pci230: simplify interrupt enable handling drivers/staging/comedi/drivers/amplc_pci230.c | 977 ++++++++++---------------- 1 file changed, 384 insertions(+), 593 deletions(-) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel