On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: > > Same comments as the previous ones, please redo all of these patches. > > > Should all the alterations be in one big single patch, insted of small ones? Your first version broke the build if we applied only the first patch. That's not allowed. Also the new rtw_sys_remove_one() function isn't called. I was confused by it as well. It doesn't "remove one", it removes everything. Do we need to support llseek? How have you tested this? Have you tested module unloading? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
