Re: [PATCH 3/6] Staging: bcm: IPv6Procotol.c: Replaced member accessing with variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 28, 2014 at 06:48:20PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer <mail@xxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/bcm/IPv6Protocol.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c
> index 5bcdaf9..c5bbb14 100644
> --- a/drivers/staging/bcm/IPv6Protocol.c
> +++ b/drivers/staging/bcm/IPv6Protocol.c
> @@ -289,6 +289,8 @@ static bool MatchSrcIpv6Address(struct bcm_classifier_rule *pstClassifierRule,
>  	UINT uiIpv6AddrNoLongWords = 4;
>  	ULONG aulSrcIP[4];
>  	struct bcm_mini_adapter *Adapter = GET_BCM_ADAPTER(gblpnetdev);
> +	union u_ip_address *src_adr = &pstClassifierRule->stSrcIpAddress;

Use 'src_addr' so it's consistent with the 'dest_addr' you use in the
other patches.  We can afford an extra 'd' character.  :P

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux