Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-07-28 at 09:58:12 +0200, Anil Belur <askb23@xxxxxxxxx> wrote:
> From: Anil Belur <askb23@xxxxxxxxx>
> 
> - private_ioctl() the internally calls copy_{to,from}_user() and does
>   not use '__user' while refrencing user space pointers.
> - this patch passes __user annotation as a cast, when the pointer is
>  being refernced.

Wouldn't it be better to annotate the data member in struct tagSCmdRequest
with __user instead of introducing all these casts?
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux