On Mon, Jul 21, 2014 at 08:36:02AM -0500, Romer, Benjamin M wrote:
> On Sat, 2014-07-19 at 09:36 -0700, Greg KH wrote:
>
> > > /* /sys/devices/platform/visorchipset */
> > > static struct platform_device Visorchipset_platform_device = {
> > > .name = "visorchipset",
> > > .id = -1,
> > > + .dev.groups = visorchipset_dev_groups,
> >
> > Only create this device when ControlVm_channel is present in the system,
> > that should take out your check for it in the show/store function.
> >
> > Same goes for the rest of these patches.
> >
> > thanks,
> >
> > greg k-h
>
> I'm not sure I understand. Do you mean that we should only create sysfs
> devices dynamically, and not use a static here?
Ideally yes. But that's not what I was referring to.
Only create this sysfs device when ControlVm_channel is created, that
way you will not have to check for it in your sysfs show/store
functions.
> I assume that any other sysfs devices in our driver set created this way
> would have the same issue?
yes.
thanks
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
