Re: [PATCH 1/8] staging: unisys: add toolaction to sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2014-07-19 at 09:36 -0700, Greg KH wrote:

> >  /* /sys/devices/platform/visorchipset */
> >  static struct platform_device Visorchipset_platform_device = {
> >  	.name = "visorchipset",
> >  	.id = -1,
> > +	.dev.groups = visorchipset_dev_groups,
> 
> Only create this device when ControlVm_channel is present in the system,
> that should take out your check for it in the show/store function.
> 
> Same goes for the rest of these patches.
> 
> thanks,
> 
> greg k-h

I'm not sure I understand. Do you mean that we should only create sysfs
devices dynamically, and not use a static here?

I assume that any other sysfs devices in our driver set created this way
would have the same issue?

-- 
Ben Romer | Software Engineer |
Virtual Systems Development 

Unisys Corporation |  2476
Swedesford Rd |  Malvern, PA 19355
|  610-648-7140



_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux