On 2014-07-18 22:28, H Hartley Sweeten wrote:
comedi_fops.c also still has a couple: CHECK: if this code is redundant consider removing it Two of them deal with #if 0'ed code in do_lock_ioctl() and do_unlock_ioctl(). The disabled code would call the subdevice (*lock_f) and (*unlock) callbacks. I'm not sure why this code is disabled. Hopefully Ian can provide some info.
It was added in comedi-0.7.6 back in June 1999 and has always been commented out. Should be safe to remove it!
There is also some disabled code in do_chaninfo_ioctl() that does a copy_to_user(). Again, I'm not sure why this is disabled.
It was replaced by the code above it in comedi-0.7.40, although the format of the rangelist[] values returned to the user changed in comedi-0.7.43. I need to check what uses the various bits of the rangelist[] elements. Putting the minor device number in there doesn't seem terribly useful, for example, especially as only 4 bits are provided to hold it.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
