Re: [PATCH 0/7] staging: comedi: core: checkpatch.pl --strict cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 18, 2014 at 02:28:09PM -0700, H Hartley Sweeten wrote:
> This series fixes most of the checkpatch.pl --strict issues in the comedi
> core files.
> 
> comedidev.h still has a couple:
> 
> CHECK: spinlock_t definition without comment
> CHECK: struct mutex definition without comment
> CHECK: Avoid CamelCase: <RANGE_mA>
> CHECK: Avoid CamelCase: <UNIT_mA>
> CHECK: Avoid CamelCase: <range_0_20mA>
> CHECK: Avoid CamelCase: <range_4_20mA>
> CHECK: Avoid CamelCase: <range_0_32mA>
> 
> I'm hoping Ian Abbot can add some comments about the spinlock_t and mutex
> definitions.
> 
> The CamelCase ones are easy to fix but I think 'mA' is easier to read
> than 'MA' or 'ma'.

Yeah, don't worry about that, it's fine.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux