On Fri, Jul 18, 2014 at 09:35:13PM +0300, Igor Bezukh wrote: > Since there is a lot of stuff that need to be changed in order to meet the kernel > coding style in wcmd.c file, I've decided to fix function-per-patch. > The following changes were made in vCommandTimerWait function: > > - Camel case change: > - MSecond ---> msec > - hDdeviceContext ---> private > - pDevice ---> priv > - Removed redundant return > - Removed redndant comment > > In future patches, I will also change the function name itself. A better way to do this, that is easier to review, is to do, on a per-file basis, one thing, like "remove redundant return", or "remove unneeded comments". Having to review all of these changes at once, even for something as "small" as a single function, is much harder than making sure you only do one thing, and do it all at once. So, can you break it up in this way instead? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
