Since there is a lot of stuff that need to be changed in order to meet the kernel coding style in wcmd.c file, I've decided to fix function-per-patch. The following changes were made in vCommandTimerWait function: - Camel case change: - MSecond ---> msec - hDdeviceContext ---> private - pDevice ---> priv - Removed redundant return - Removed redndant comment In future patches, I will also change the function name itself. Signed-off-by: Igor Bezukh <igbzkh@xxxxxxxxx> --- drivers/staging/vt6655/wcmd.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/wcmd.c b/drivers/staging/vt6655/wcmd.c index a689645..e5073d9 100644 --- a/drivers/staging/vt6655/wcmd.c +++ b/drivers/staging/vt6655/wcmd.c @@ -281,21 +281,15 @@ s_MgrMakeProbeRequest( return pTxPacket; } -void -vCommandTimerWait( - void *hDeviceContext, - unsigned int MSecond -) +void vCommandTimerWait(void *private, unsigned int msec) { - PSDevice pDevice = (PSDevice)hDeviceContext; + PSDevice priv = (PSDevice)private; - init_timer(&pDevice->sTimerCommand); - pDevice->sTimerCommand.data = (unsigned long) pDevice; - pDevice->sTimerCommand.function = (TimerFunction)vCommandTimer; - // RUN_AT :1 msec ~= (HZ/1024) - pDevice->sTimerCommand.expires = (unsigned int)RUN_AT((MSecond * HZ) >> 10); - add_timer(&pDevice->sTimerCommand); - return; + init_timer(&priv->sTimerCommand); + priv->sTimerCommand.data = (unsigned long)priv; + priv->sTimerCommand.function = (TimerFunction)vCommandTimer; + priv->sTimerCommand.expires = (unsigned int)RUN_AT((msec * HZ) >> 10); + add_timer(&priv->sTimerCommand); } void -- 1.7.9.5 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel