On 2014-07-16 17:36, Hartley Sweeten wrote:
On Wednesday, July 16, 2014 3:54 AM, Ian Abbott wrote:
On 2014-07-14 20:23, H Hartley Sweeten wrote:
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the "common" driver support. This series does some
more cleanup to get the file closer to being changed into a module instead
of including it in the drivers.
Jolly good!
One thing you missed is simplifying ni_ao_config_chanlist(),
ni_old_ao_config_chanlist() and ni_m_series_ao_config_chanlist() a
little more by changing them to return 'void' and removing the 'invert'
variable from ni_old_ao_config_chanlist().
The ni_mio_common stuff still needs additional cleanup. I'll get
around to tidying up the config_chanlist stuff eventually. ;-)
Okay. I just thought I'd mention it because your patches were changing
those functions anyway!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
