On 2014-07-14 20:23, H Hartley Sweeten wrote:
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the "common" driver support. This series does some
more cleanup to get the file closer to being changed into a module instead
of including it in the drivers.
H Hartley Sweeten (28):
staging: comedi: mite.h: tidy up the mite channel register offsets
staging: comedi: comedidev.h: introduce some 'range_is_external' helpers
staging: comedi: ni_stc.h: remove 'ao_unipolar' flag from ni_board_struct
staging: comedi: ni_mio_common: fix ni_ao_insn_write_671x()
staging: comedi: ni_mio_common: remove ao_win_out() macro
staging: comedi: ni_mio_common: fix ni_ao_insn_write()
staging: comedi: ni_stc.h: add some 'is_{board type}' flags to private data
staging: comedi: ni_mio_common: tidy up ni_ao_munge()
staging: comedi: ni_mio_common: remove INSN_CONFIG_ANALOG_TRIG support code
staging: comedi: ni_mio_common: remove some unnecessary boardinfo access
staging: comedi: ni_mio_common: merge analog output (*insn_write) functions
staging: comedi: ni_mio_common: remove ai_continuous from private data
staging: comedi: ni_mio_common: fix ni_ao_insn_read()
staging: comedi: ni_mio_common: remove unnecessary use of 'board->adbits'
staging: comedi: ni_stc.h: refactor 'adbits' boardinfo
staging: comedi: ni_stc.h: refactor 'aobits' boardinfo
staging: comedi: ni_mio_common: (*cancel) only works with async cmd support
staging: comedi: ni_mio_common: tidy up the Analog Input subdevice init
staging: comedi: ni_mio_common: tidy up the Analog Output subdevice init
staging: comedi: ni_mio_common: refactor 'num_p0_dio_channels' boardinfo
staging: comedi: ni_mio_common: tidy up the Digital I/O subdevice init
staging: comedi: ni_mio_common: init clock dividers early in ni_E_init()
staging: comedi: ni_mio_common: only reset the ai/ao subdevices if they exist
staging: comedi: ni_mio_common: tidy up the calibration subdevice init
staging: comedi: ni_mio_common: tidy up the EEPROM subdevice init
staging: comedi: ni_mio_common: tidy up the PFI subdevice init
staging: comedi: ni_mio_common: tidy up the gpct counter subdevice init
staging: comedi: ni_mio_common: tidy up the frequency output subdevice init
drivers/staging/comedi/comedidev.h | 13 +
drivers/staging/comedi/drivers/mite.h | 106 +---
drivers/staging/comedi/drivers/ni_atmio.c | 44 +-
drivers/staging/comedi/drivers/ni_mio_common.c | 753 +++++++++++--------------
drivers/staging/comedi/drivers/ni_mio_cs.c | 24 +-
drivers/staging/comedi/drivers/ni_pcimio.c | 289 ++++------
drivers/staging/comedi/drivers/ni_stc.h | 24 +-
7 files changed, 508 insertions(+), 745 deletions(-)
Jolly good!
One thing you missed is simplifying ni_ao_config_chanlist(),
ni_old_ao_config_chanlist() and ni_m_series_ao_config_chanlist() a
little more by changing them to return 'void' and removing the 'invert'
variable from ni_old_ao_config_chanlist().
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
