Re: [PATCH] Staging: rtl8821ae: fix coding style issue in cam.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
> This is a patch to the cam.c file that fix a coding style error (do not use C99 // comments)
> Signed-off-by: Joerg C. Meyer <joerg@xxxxxxxxxxxxxxxxx>

Minor nit, you need a blank line between these two lines...

> ---
>  drivers/staging/rtl8821ae/cam.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
> index 3bc6b3d..9c0cd1e 100644
> --- a/drivers/staging/rtl8821ae/cam.c
> +++ b/drivers/staging/rtl8821ae/cam.c
> @@ -152,7 +152,7 @@ u8 rtl_cam_add_one_entry(struct ieee80211_hw *hw, u8 *mac_addr,
>  	return 1;
>  
>  }
> -//EXPORT_SYMBOL(rtl_cam_add_one_entry);
> +/* EXPORT_SYMBOL(rtl_cam_add_one_entry); */

Your patch is correct, but how about just deleting these lines instead?
They aren't needed, so please remove them.

Can you do that and resend?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux