Hi, 2014-07-10 4:02 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: >> Null checks for tty, un and ch are already done by caller, >> so replace parameter "tty" with "ch" and "un". >> >> And also use a pointer for returning new bytes_available instead of >> return variable. > > Why make that change? It's nicer to return a real value where ever > possible. That's more like other "room" functions in the tty layer. I was looking at use cases of dgap_maxcps_room() in dgap.c, byte_available variable in caller is reused for that. So I tried to change like this patch. > > Care to fix this up to just do the first change you made to the function > instead? OK, I will just change parameters for dgap_maxcps_room() and send again. thanks. regards, Daeseok Youn. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
