On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: > Null checks for tty, un and ch are already done by caller, > so replace parameter "tty" with "ch" and "un". > > And also use a pointer for returning new bytes_available instead of > return variable. Why make that change? It's nicer to return a real value where ever possible. That's more like other "room" functions in the tty layer. Care to fix this up to just do the first change you made to the function instead? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel