On Fri, Jun 20, 2014 at 11:46:45AM -0700, Greg KH wrote: > On Fri, Jun 20, 2014 at 09:39:26PM +0300, Kristina Mart??enko wrote: > > On 20/06/14 19:52, Willy Tarreau wrote: > > > Hi Kristina, > > > > > > On Fri, Jun 20, 2014 at 06:35:03PM +0300, Kristina Mart?enko wrote: > > >> Hi Willy, > > >> > > >> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > > >> nobody seems to have worked towards moving panel out of staging in over > > >> a year. Are there any plans to clean it up and move it out soon? Because > > >> otherwise we're going to have to delete the driver, as we don't want > > >> staging to become a permanent place for unfinished code. > > > > > > In fact I think we're facing the edge of the staging driver model : it > > > works fine for everyone and people are used to use it from there. I'm > > > absolutely convinced that this is the worst thing to do, but we're in > > > the situation where doing nothing ensures it continues to work. It was > > > submitted a long time ago by a user. I was not very happy by this since > > > I knew I wouldn't be the person doing the clean up, but I understand > > > that it allows users to have it ready. > > > > Yes, I know what you mean. On the other hand, if we keep it around, we > > have to keep every other staging driver around for the same reason - > > that it works, and somebody might want to use it. The end result is that > > there's an ever increasing amount of code in the kernel that's low > > quality, and will probably always be so. > > > > > Since then, there have been > > > multiple cleanup passes, I'm not even sure if it still makes sense that > > > it remains in staging now. > > > > That's good, though if you don't know, then I think probably no one > > does. It's the problem of staging : it works too well ; most users are fine with what they find there, and they don't comment on what they use. Maybe we should make staging more painful to use (eg: cause a 1-second pause after the warning is emitted and say that if you want this pause to disappear, you should help take that driver out of staging). > > Someone should probably review it. Agreed! > > > If some help is needed from my side to move > > > it to drivers/misc, I'll participate, of course, but I clearly won't > > > spend a whole week rewriting it differently for example. > > > > Do you want to review it? The TODO file says the userspace API and > > major/minor usages need checking. Since nobody updates the TODO after even minor updates, I don't know if that's still relevant. > > If not, then Greg, what do you think would be the best thing to do with > > this driver? > > Let me put it on my list of things to review, and I will look at it in a > few weeks when I get back from my next round of trips. That would be great. My own review would be biased because I wrote it myself (a long time ago) so I would not find it ugly even if it is. Greg, don't waste your time though. Just take a quick look and if you think it is OK, fine, otherwise if you think that issues are fixable in 2-3 evenings, I'll do them, otherwise we'll simply mark it for deletion and wait to see if someone steps up. I can also ask among my coworkers if someone is interested in taking over it if some work is still needed. Thanks, Willy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
