On 20/06/14 19:52, Willy Tarreau wrote: > Hi Kristina, > > On Fri, Jun 20, 2014 at 06:35:03PM +0300, Kristina Mart?enko wrote: >> Hi Willy, >> >> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >> nobody seems to have worked towards moving panel out of staging in over >> a year. Are there any plans to clean it up and move it out soon? Because >> otherwise we're going to have to delete the driver, as we don't want >> staging to become a permanent place for unfinished code. > > In fact I think we're facing the edge of the staging driver model : it > works fine for everyone and people are used to use it from there. I'm > absolutely convinced that this is the worst thing to do, but we're in > the situation where doing nothing ensures it continues to work. It was > submitted a long time ago by a user. I was not very happy by this since > I knew I wouldn't be the person doing the clean up, but I understand > that it allows users to have it ready. Yes, I know what you mean. On the other hand, if we keep it around, we have to keep every other staging driver around for the same reason - that it works, and somebody might want to use it. The end result is that there's an ever increasing amount of code in the kernel that's low quality, and will probably always be so. > Since then, there have been > multiple cleanup passes, I'm not even sure if it still makes sense that > it remains in staging now. That's good, though if you don't know, then I think probably no one does. Someone should probably review it. > If some help is needed from my side to move > it to drivers/misc, I'll participate, of course, but I clearly won't > spend a whole week rewriting it differently for example. Do you want to review it? The TODO file says the userspace API and major/minor usages need checking. If not, then Greg, what do you think would be the best thing to do with this driver? Thanks for responding so quickly, Kristina _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
