On Tue, Jun 17, 2014 at 11:59:20PM +0900, Masanari Iida wrote:
> This patch removed trailing semicolon from macro in guestlinuxdebug.h
>
> Signed-off-by: Masanari Iida <standby24x7@xxxxxxxxx>
> ---
> drivers/staging/unisys/include/guestlinuxdebug.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/unisys/include/guestlinuxdebug.h b/drivers/staging/unisys/include/guestlinuxdebug.h
> index efc4005..b4b4794 100644
> --- a/drivers/staging/unisys/include/guestlinuxdebug.h
> +++ b/drivers/staging/unisys/include/guestlinuxdebug.h
> @@ -168,15 +168,15 @@ do { \
>
> /* MOST COMMON */
> #define POSTCODE_LINUX_2(EVENT_PC, severity) \
> - POSTCODE_LINUX_A(CURRENT_FILE_PC, EVENT_PC, 0x0000, severity);
> + POSTCODE_LINUX_A(CURRENT_FILE_PC, EVENT_PC, 0x0000, severity)
>
> #define POSTCODE_LINUX_3(EVENT_PC, pc32bit, severity) \
> - POSTCODE_LINUX_A(CURRENT_FILE_PC, EVENT_PC, pc32bit, severity);
> + POSTCODE_LINUX_A(CURRENT_FILE_PC, EVENT_PC, pc32bit, severity)
>
>
> #define POSTCODE_LINUX_4(EVENT_PC, pc16bit1, pc16bit2, severity) \
> POSTCODE_LINUX_B(CURRENT_FILE_PC, EVENT_PC, pc16bit1, \
> - pc16bit2, severity);
> + pc16bit2, severity)
Given that the code does not even build at all, how did you test this
change would not break something?
Also, side note, this is _horrid_ code. Macros creating macros all
around a other macros that eventually call unisys_extended_vmcall
because someone didn't want to just call it directly in the code for
some odd, unknown reason (hint, if it takes 3 levels of #defines to make
a single function call, that function call might need some work in
making it easier to use properly...)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
