Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote:
> The unisys drivers now properly check to make sure they are running
> on the s-Par platform before they will initialize.  This was fixed in
> commit fcd0157ece so it is safe to allow the unisys drivers to be built.
> 
> This has been tested in the same qemu environment that originally
> produced the panic and the kernel now runs as expected.

It hasn't been tested on a build, as this breaks the build on my machine
in tons of horrible ways (hint __DATE__ and __TIME__ are no longer
allowed in kernel code...)

> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Reported-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
> Tested-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> Tested-by: Ken Cox <jkc@xxxxxxxxxx>
> Signed-off-by: Ken Cox <jkc@xxxxxxxxxx>

I'm getting really frustrated at this unisys code.  It's been marked
broken for a number of kernel releases now, and the changes that have
been sent in so far are just cosmetic things, no "real" cleanups.  Given
that I had to _ask_ for this patch, I'm guessing that no one really
cares about the code at all :(

So, I can't take this, patch, sorry.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux