Re: [PATCH] staging: remove non-ascii-characters from HalBtc8812a1Ant.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 14, 2014 at 08:56:34PM +0200, Toralf Förster wrote:
> those characters breaks the html-formatter tool of Cppcheck
> 

Cppcheck should be fixed.

> Signed-off-by: Toralf Förster <toralf.foerster@xxxxxx>
> ---
>  drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c b/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
> index 5a54bb1..e7fa7f4 100644
> --- a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
> +++ b/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
> @@ -1670,7 +1670,7 @@ halbtc8812a1ant_TdmaDurationAdjustForAcl(
>  			if (dn <= 0)
>  				dn = 0;				 
>  
> -			if(up >= n)	// if ?s?? n ??2?? retry count??0, ?h?ռeWiFi duration
> +			if(up >= n)	// 

Leaving an empty comment just to annoy checkpatch.pl is a pointless
thing.

These are Chinese comments.  According to google translate it means:
"if consecutive n-2 seconds retry count is 0, width-modulated WiFi duration"

Git hub has a better html generator than cppcheck so you can admire the
original Chinese characters and cut and paste.
https://github.com/Canonical-kernel/Ubuntu-kernel/blob/master/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c

regarsd,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux