Re: [PATCH] staging: keucr: usb.c: add blank lines after declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2014 at 11:13:57PM +0200, Mathias Engan wrote:
> On Wed, Jun 11, 2014 at 01:50:51PM -0700, Greg KH wrote:
> > On Wed, Jun 11, 2014 at 10:23:09PM +0200, mathias.engan@xxxxxxxxx wrote:
> > > From: Mathias Engan <mathias.engan@xxxxxxxxx>
> 
> > >  static int eucr_suspend(struct usb_interface *iface, pm_message_t message)
> > >  {
> > >  	struct us_data *us = usb_get_intfdata(iface);
> > > +
> > >  	pr_info("--- eucr_suspend ---\n");
> > > +
> > 
> > Did checkpatch complain about this line not being here?  Because that's
> > not what you said above in the patch description :(
> > 
> Ah. No. It did not. However, in the previous, and most of the following
> functions there is a blank line after pr_info() so I added it so that
> eucr_suspend() would conform to the style of the other, similar, functions.
> 
> Would you like me to resubmit or change the patch description?

Resubmit and don't make that change, just do what you said you are
doing, don't do other things...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux