These would have been easier to review if this patch were folded in with the previous two patches. What I look for in these patches is, "Will the compile break if you get it wrong?" For "[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to padapter->chip_type directly", you could get it wrong and the compile wouldn't break so I have to go into the code and look at it. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel