Re: [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
> Fixed the following:
> 
> ERROR: do not use C99 // comments
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ';' (ctx:VxV)
> ERROR: space required before the open brace '{'
> ERROR: spaces required around that '=' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: space required after that close brace '}'
> ERROR: spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> 

All of these patches have the same subject.  And also they aren't
broken up in the correct way.  Basically for this kind of thing we want
to see one kind of cleanup per patch.

[patch 1/6] Staging: rtl8192u: add missing spaces
[patch 2/6] Staging: rtl8192u: delete commented out code
[patch 3/6] Staging: rtl8192u: clean up c99 comments
[patch 4/6] Staging: rtl8192u: reformat long lines
...

Etc.

Sorry for asking people to redo these again...

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux