Re: [PATCH 05/74] staging: rtl8723au: Fix up some random bit-flag handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 21, 2014 at 09:37:29AM +0200, Jes.Sorensen@xxxxxxxxxx wrote:
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
> index b912d09..8c6b094 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
> @@ -1027,9 +1027,8 @@ rtw_joinbss_update_stainfo(struct rtw_adapter *padapter,
>  		/* security related */
>  		if (padapter->securitypriv.dot11AuthAlgrthm ==
>  		    dot11AuthAlgrthm_8021X) {
> -			padapter->securitypriv.binstallGrpkey = false;
> -			padapter->securitypriv.busetkipkey = false;
> -			padapter->securitypriv.bgrpkey_handshake = false;
> +			padapter->securitypriv.binstallGrpkey = 0;
> +			padapter->securitypriv.busetkipkey = 0;
>  

You remove ->bgrpkey_handshake in this patch.  That's fine because it
is a write-only variable.  But that's should be in a separate patch and
described in the changelog next time.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux