Re: [PATCH 04/74] staging: rtl8723au: HalEEValueCheck(): content of a u8 is always >= 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 21, 2014 at 09:37:28AM +0200, Jes.Sorensen@xxxxxxxxxx wrote:
> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index e2d426a..0afc742 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -1720,9 +1720,9 @@ static void Hal_EEValueCheck(u8 EEType, void *pInValue, void *pOutValue)
>  		u8 *pIn, *pOut;
>  		pIn = (u8 *) pInValue;
>  		pOut = (u8 *) pOutValue;
> -		if (*pIn >= 0 && *pIn <= 63) {
> +		if (*pIn <= 63)
>  			*pOut = *pIn;
> -		} else {
> +		else {

Don't resend but the curly braces were the correct kernel style in the
original.  If one side gets braces then both do.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux