So, Jake, you're right, but if he redoes patch 2/6 then he has to redo the rest as well. The bad names were bad in the original code already, so normally we let people fix things up in follow on patches in that case. Is that ok with you? I totally do appreciate your review comments and agree with them. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel