On Sat, May 17, 2014 at 10:14:52PM +0100, Masaru Nomura wrote: > > Also just fold this patch and [patch 2/4] together into one patch. We > > don't need two patches to fix one if statement. > > > > The one thing per patch rule is a bit tricky. It means that you have to > > say which one thing you are fixing. Don't say "I am fixing three > > things." Say "I am fixing one if statement". > > So in this case, do you think I could fold all four patches into one? No. That would be more than one thing per patch. It looks like this: [patch 1/3] staging: dgnc: dgnc_neo: put else statements on the right line [patch 2/3] staging: dgnc: dgnc_neo: clean up ugly one very ugly condition [patch 3/3] staging: dgnc: dgnc_neo: remove extra curly braces Each patch does one thing. Cleaning up the whole file is too big so it doesn't count as doing one thing only. > As I just worked on the 'same' if statements and divided them into > four patches, this could be the case. (but I'm not sure yet...) > > Also, should I put v[number] for the modified patches? > Say [PATCH v2] staging: ... Yes. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
