Am 2014-05-17 19:21, schrieb Antti Palosaari: > On 05/17/2014 07:05 PM, Martin Kepplinger wrote: >> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. >> use the common kernel coding style. >> >> Signed-off-by: Martin Kepplinger <martink@xxxxxxxxx> > > Reviewed-by: Antti Palosaari <crope@xxxxxx> > >> --- >> this applies to next-20140516. any more suggestions? >> more cleanup can be done when dprintk() is completely gone. > > Do you have the device? I am a bit reluctant patching that driver > without any testing as it has happened too many times something has gone > totally broken. I don't have the device and will, at most, change such style issues. > > IIRC Devin said it is in staging because of style issues and nothing > more. Is that correct? I haven't heard anything. A TODO file would help. > > regards > Antti > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
