Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: > On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: >> Thanks so much, I greatly appreciate the review. I'll fix the >> changelog for patch 4 and send once more (as I assume that's easier >> for Greg). Also, I should know better about the cover letter as >> well...I was once told not to send them for strictly cleanup patchsets >> (as Greg can't do anything with them and cleanups should be obvious) >> but I've gotten in the habit of not doing a cover letter for any >> patchsets. I will send cover letters (and be more careful about my >> other mistakes) in the future. > > Chase, > > Good job on the cleanup you have done so far. > > The cover letter does not get committed as part of the patch set. But > when you are submitting a series it give a convenient place to add > the sign off tag for a series. Also, if you would have done a cover letter > for this series you would have probably spotted the subject line issues > in patches 5 and 6. > > Keep up the good work! > > Hartley > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
