Ian and Hartley, Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg can't do anything with them and cleanups should be obvious) but I've gotten in the habit of not doing a cover letter for any patchsets. I will send cover letters (and be more careful about my other mistakes) in the future. Thanks, Chase On Tue, Apr 29, 2014 at 3:33 PM, Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: > On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: >> This driver no longer reads the eeprom to find the board specific data, >> all the necessary data is in the boardinfo. Use the boardinfo directly >> instead of passing through devpriv->s_EeParameters. >> >> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> --- >> 2: Incorrect patch title fixed. >> >> Ian and Hartley, >> >> The auto_attach() function is starting to look much better now. My next patchset >> will be geared towards only allocating subdevices which are actually used. > > Other than Ian's comment on patch 4/6 everything looks good to me. > > For the series: > Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > > BTW, for a patch series you should include a cover letter (PATCH 00/xx). > > Regards, > Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
