Re: [PATCH 00/47] Lustre fixes and cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 27, 2014 at 01:06:24PM -0400, Oleg Drokin wrote:
> Hello!
> 
>    This pile of patches brings in most of the recent fixes from
>    current Lustre development tree, also code cleanups, junk removal
>    and such.
>    A relatively unsynced area remaining is in client io stack
>    that is undergoing some major shakeups now, I'll try to tackle
>    it later once things actually settle down some more.

I've applied these, except for the 3 gss patches.

Also, there is now a build warning in the tree thanks to these, please
send a follow-on patch to fix it before you get an email from the 0-day
bot about it.

>    There are several checkpatch warnings in this patchset that
>    I am not sure what to do aobut since the messages printed are
>    genuinely long:
> 
> WARNING: quoted string split across lines
> #61: FILE: drivers/staging/lustre/lustre/ptlrpc/import.c:1424:
> +		CERROR("%s: don't know how to disconnect from %s "
> +		       "(connect_op %d): rc = %d\n",
> 
> total: 0 errors, 1 warnings, 73 lines checked

Strings all need to go on one line, and you all need to take out your
"special" logging macros so that checkpatch will know what to do with
them.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux