> -----Original Message----- > From: Andev [mailto:debiandev@xxxxxxxxx] > Sent: Thursday, April 24, 2014 2:50 PM > To: KY Srinivasan > Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; LKML; > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; > jasowang@xxxxxxxxxx > Subject: Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on > the send path > > On Wed, Apr 23, 2014 at 5:24 PM, K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > wrote: > > > drivers/net/hyperv/hyperv_net.h | 14 +++ > > drivers/net/hyperv/netvsc.c | 226 > +++++++++++++++++++++++++++++++++++++-- > > drivers/net/hyperv/netvsc_drv.c | 3 +-> 3 files changed, 234 > insertions(+), 9 deletions(-) > > I just looked over netvsc.c and it could definitely use a more consistent > coding style. > > Your use of goto exit/cleanup in some functions and returning directly on > errors in others could use a cleanup. Please consider doing that while you are > touching those files. Will do. The most recent changes I made to netvsc.c, I think was consistent with the existing code; going forward we will certainly move towards a more consistent coding style. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
