On Wed, Apr 23, 2014 at 5:24 PM, K. Y. Srinivasan <kys@xxxxxxxxxxxxx> wrote: > drivers/net/hyperv/hyperv_net.h | 14 +++ > drivers/net/hyperv/netvsc.c | 226 +++++++++++++++++++++++++++++++++++++-- > drivers/net/hyperv/netvsc_drv.c | 3 +-> 3 files changed, 234 insertions(+), 9 deletions(-) I just looked over netvsc.c and it could definitely use a more consistent coding style. Your use of goto exit/cleanup in some functions and returning directly on errors in others could use a cleanup. Please consider doing that while you are touching those files. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
