On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: > On Wed, Apr 16, 2014 at 11:39 AM, Greg KH <greg@xxxxxxxxx> wrote: > > On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > >> On 04/10/2014 07:56 PM, Greg KH wrote: > >> > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: > >> >>> That's pretty obviously not going to apply properly, you have line-wrapp > >> >>> on. You can't cut-and-paste patches into gmail, see > >> >>> Documentation/email_clients.txt for details. > >> >>> > >> >>> thanks, > >> >>> > >> >>> greg k-h > >> >>> > >> >> I'm so sorry about that. I already read it and configured Thunderbird as recommended. I just forgot to turn line wrap off. > >> > > >> > That worked, as this line shows :) > >> > > >> > But you put the patch at the end of the email, I can't do anything with > >> > it, I need it as a "clean" email, something I don't have to edit by hand > >> > when applying. > >> > > >> > Also... > >> > > >> >> -static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter, PVOID pvEthPayload, struct bcm_eth_packet_info *pstEthCsPktInfo); > >> >> -static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter, struct sk_buff* skb, struct bcm_eth_packet_info *pstEthCsPktInfo, struct bcm_classifier_rule *pstClassifierRule, B_UINT8 EthCSCupport); > >> >> +static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter, > >> >> + PVOID pvEthPayload, struct bcm_eth_packet_info *pstEthCsPktInfo); > >> >> + > >> >> +static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter, > >> >> + struct sk_buff *skb, struct bcm_eth_packet_info *pstEthCsPktInfo, > >> >> + struct bcm_classifier_rule *pstClassifierRule, B_UINT8 EthCSCupport); > >> >> > >> >> static USHORT IpVersion4(struct bcm_mini_adapter *Adapter, struct iphdr *iphd, > >> >> - struct bcm_classifier_rule *pstClassifierRule); > >> >> + struct bcm_classifier_rule *pstClassifierRule); > >> > > >> > What happened to the tabs? > >> > > >> > And why modify this last line, what was wrong with it? > >> > > >> > thanks, > >> > > >> > greg k-h > >> > > >> > >> Greg, > >> > >> Where you able to apply the patch successfully? > > > > I asked above what happened to the tabs, and why modify that line, so > > no, I did not apply it, as it doesn't look correct to me. > > > > thanks, > > > > greg k-h > > In the last patch I sent, I believe I addressed the why modify that line issue. > However, I just realized that for whatever reason my tabs are being converted > to spaces when sending the email. I'll try to work around this. What email > client do you recommend for submitting patches? mutt. > Also, I sent a v2 patch and received and auto response from you. Should I > submitted the fixed patch as a v3 or continue in this thread? What auto response? That the patch was applied, or not? I'm totally lost, sorry. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
