> -----Original Message----- > From: H. Peter Anvin [mailto:hpa@xxxxxxxxx] > Sent: Monday, April 14, 2014 10:08 AM > To: KY Srinivasan; x86@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; > JBeulich@xxxxxxxx > Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic > appropriately > > On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: > > + new_val = inb(PIC_MASTER_IMR); > > + if (probe_val != new_val) { > > Nitpick: Linux coding style should have this as: > > if (new_val != probe_val) > > -hpa > Will address this as well. K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
