On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: > + new_val = inb(PIC_MASTER_IMR); > + if (probe_val != new_val) { Nitpick: Linux coding style should have this as: if (new_val != probe_val) -hpa _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel