On Thu, Apr 03, 2014 at 01:24:04PM -0500, Aaron Sierra wrote: > ----- Original Message ----- > > From: "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> > > Sent: Thursday, April 3, 2014 1:05:03 PM > > > > On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > > > From: Joe Schultz <jschultz@xxxxxxxxxxx> > > > > > > This patch corrects a failure to dereference a pointer in > > > tsi148_slave_get(). > > > > If you had a dmesg output of the crash it would be great to include it > > here. The commit message would be clearer if it said, "There is a > > typo where we use "vme_base" instead of "*vme_base". > > Dan, > There is no crash that I can demonstrate based on our use of the > function (via vme_user). As we experience it, the failure to deference > simply results in an incorrect value being returned to userspace and > the compile warning. Fine fine. Put that in the commit. "This results in a wrong value being returned to userspace". regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
