Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote:
> From: Joe Schultz <jschultz@xxxxxxxxxxx>
> 
> This patch corrects a failure to dereference a pointer in tsi148_slave_get().

If you had a dmesg output of the crash it would be great to include it
here.  The commit message would be clearer if it said, "There is a
typo where we use "vme_base" instead of "*vme_base".

> It also removes the following compile warning on some platforms:
> 
> warning: cast from pointer to integer of different size
> 
> Signed-off-by: Joe Schultz <jschultz@xxxxxxxxxxx>

Aaron, we need your Signed-off-by as well as Joe's since the patch went
through your hands.  Please resend.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux