On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote: > Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Please use "scripts/checkpatch.pl --strict" on patches to files in drivers/staging. CHECK: Alignment should match open parenthesis #75: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:646: + pr_debug("cmdresult:status=0x%04x resp0=0x%04x resp1=0x%04x resp2=0x%04x\n", + result->status, result->resp0, CHECK: Alignment should match open parenthesis #99: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:1383: + pr_debug("cmdreq: cmd=0x%04x parm0=0x%04x parm1=0x%04x parm2=0x%04x\n", + cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2); CHECK: Alignment should match open parenthesis #109: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2019: + netdev_info(hw->wlandev->netdev, + "Download %d bytes to flash @0x%06x\n", len, daddr); CHECK: Alignment should match open parenthesis #120: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2030: + netdev_warn(hw->wlandev->netdev, + "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr, CHECK: Alignment should match open parenthesis #133: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2065: + netdev_err(hw->wlandev->netdev, + "download(NV,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n", CHECK: Alignment should match open parenthesis #154: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2354: + netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n", + len, daddr); CHECK: Alignment should match open parenthesis #164: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2465: + netdev_err(hw->wlandev->netdev, + "pdrlen invalid=%d\n", pdrlen); CHECK: Alignment should match open parenthesis #174: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2788: + netdev_err(hw->wlandev->netdev, + "submit_tx_urb() failed, error=%d\n", ret); CHECK: Alignment should match open parenthesis #195: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4143: + pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n", + pdrcode); CHECK: Alignment should match open parenthesis #202: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4148: + pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n", + pdrcode); total: 0 errors, 2 warnings, 10 checks, 127 lines checked _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel