On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote: > Signed-off-by: Mike Sampson <mike@xxxxxxxxxxxxx> > > This fixes a sparse warning: > warning: symbol 'cfs_wi_data' was not declared. Should it be static? > Patch is ok. Signed off should go at the end instead of at the start of the commit message. The subject should be: [PATCH] Staging: lustre: mark a variable static in workitem.c Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a better prefix. Btw, for these kinds of changes, then you should be working against -next. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel