Thanks for reply. I will do that. Regards, Daeseok Youn. 2014-03-19 11:31 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: >> oh... >> You didn't get my reply about vmalloc usage. >> >> My replay attach again, below. >> >> > 2014-03-18 9:37 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: >> >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >> >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >> >>> vmalloc/kmalloc directly. >> >> >> >> Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being >> >> used, but cc: the driver maintainers just to be sure. >> > >> Here, need to check by you. >> > It try to allocate 128KiB(131072byte) with vmalloc(). I think if it >> > trying to allocate with kmalloc() >> > it has a possibility to fail because of memory fragmentation even if >> > system has enough memory to use. >> > Just my opinion. If I'm wrong, let me know. > > Check to see just how big you are allocating, you should know based on > the flags which code path happened uislib_malloc(). > > Just keep the logic the same and you should be fine. > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
