>On Friday, March 7, 2014 11:38 AM, Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: >>On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote: >>This patch fixes the register map defines for the counter registers such >>that they are all the real offsets to each register, rather than a mix of >>real offsets and adders to those offsets. >> >>Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> >>--- >> >>2: Simplified commit message, fixed indentation and whitespace damage. >>I have test applied this patch, it should work now. >>v2 also fixes several build breakages, and I have compile tested as well. >>Everything should be fixed. > >Chase, > >Looks better, the patches apply now. > >The register map whitespace is still a bit of a mess. This is what it looks like >after applying all 5 patches: > [snip] > >Check your tab settings in your editor. Normal tab spacing is 8 characters. >It looks like all the defines align properly at column 49 which is one tab after >the define on this line: > >#define APCI1564_TCW_WARN_TIMEBASE_REG(x) (0x1c + ((x) * 0x20)) > >Other than that the patches look good. OK, yeah, for whatever reason my editor was set to 4 space tabs...I suppose that explains why it looked perfectly aligned to me but horrifying to everyone else. I have fixed this setting so it shouldn't be a problem going forward. Everything appears to be properly aligned for real now, in the v3 I am sending out momentarily. Thanks, Chase >Regards, >Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
