Mauro, On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote: > Em Sat, 02 Nov 2013 20:20:54 +0100 > Paul Bolle <pebolle@xxxxxxxxxx> escreveu: > > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote: > > > drivers/media/common/siano/Kconfig:21-26 > > > > config SMS_SIANO_DEBUGFS > > > > bool "Enable debugfs for smsdvb" > > > > depends on SMS_SIANO_MDTV > > > > depends on DEBUG_FS > > > > depends on SMS_USB_DRV > > > > depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV > > > > > > The last line adds the dependency CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV. > > > This expression does not look sound as those two symbols are not declared > > > anywhere. So, the two strings CONFIG_SMS_USB_DRV and CONFIG_SMS_SDIO_DRV > > > are compared, yielding always 'n'. As a result, SMS_SIANO_DEBUGFS will never > > > be enabled. > > [...] The Kconfig logic here is that it > should depends on !SMS_SDIO_DRV or SMS_USB_DRV = SMS_SDIO_DRV. > > I remember I made a patch like that while testing some things with this > driver, but it seems that I forgot to push. I might have it somewhere on > my test machine. This line is still present in v3.14-rc2. Did you ever find that patch on your test machine? Paul Bolle _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
