Re: [PATCH] drivers: staging: lustre: lustre: include: add "attribute((packed))" for the related union

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 20 Jan 2014 16:01:16 +0300
Cc: devel@xxxxxxxxxxxxxxxxxxxx, andreas.dilger@xxxxxxxxx, Chen Gang <gang.chen.5i5j@xxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, bergwolf@xxxxxxxxx, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, oleg.drokin@xxxxxxxxx, jacques-charles.lafoucriere@xxxxxx, jinshan.xiong@xxxxxxxxx, linux-metag@xxxxxxxxxxxxxxx
Delivered-to: driverdev-devel@xxxxxxxxxx
In-reply-to: <20140120125603.GD4815@mwanda>
User-agent: Mutt/1.5.21 (2010-09-15)

Are you sure it's padding the unions, and not just treating the unions
as structs?  What is the size of this union?

union a {
	int x;
	short y;
};

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Follow-Ups:
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: James Hogan

References:
- [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Chen Gang
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Dan Carpenter
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Chen Gang
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Dan Carpenter
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Chen Gang
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: James Hogan
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Dan Carpenter
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: James Hogan
- Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
Next by Date: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
Previous by thread: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
Next by thread: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

Re: [PATCH] drivers: staging: lustre: lustre: include: add "attribute((packed))" for the related union