On Fri, Jan 10, 2014 at 11:26:52AM +0800, Steve Underwood wrote: > Hi Greg, > > On 01/10/2014 11:09 AM, Greg KH wrote: > > On Fri, Jan 10, 2014 at 10:45:42AM +0800, Steve Underwood wrote: > >> Hi Greg, > >> > >> As David said, the echo cancellation module is widely used, and gives good > >> service. We have had no reason to touch the code for a long time. The last > >> thing I remember doing was to make a minor correction to filter gain, which > >> avoided a distortion issue some people saw. That was in August 2008. I > >> haven't heard any reports of problems since then. > >> > >> Regards, > >> Steve > >> > >> On 01/10/2014 06:39 AM, David Rowe wrote: > >>> Hi Greg, > >>> > >>> Development as been completed, and AFAIK it works just fine for many > >>> people. Is there anything that needs to be done from your side to get > >>> it merged into the kernel? Apologies if I'm missing something in the > >>> development process. > > What modules use this code, as it's really only a library. Is it > > out-of-tree drivers? > > > > thanks, > > > > greg k-h > > > Out of tree drivers are the main users - in particular, the Digium > drivers for their Asterisk telephony cards, and the Sangoma drivers for > their Wanpipe telephony cards. It is an option for the mISDN drivers in > the kernel tree, but I don't know if that is directly an option of what > is in the tree, or if you need to apply any out of tree patches to hook > mISDN into the echo canceller. I don't see any in-kernel users of the oslec_* functions, is that how they hook into the module? > The main users being out of tree drivers is the reason there has not > been big pressure to get the canceller into the tree. However, that > doesn't mean it shouldn't be there. I agree, just wanting to figure out what is going on here. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel