On Thu, Jan 9, 2014 at 7:20 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Jan 09, 2014 at 01:36:15AM -0800, Insop Song wrote: >> --- /dev/null >> +++ b/drivers/staging/gs_fpgaboot/TODO >> @@ -0,0 +1,14 @@ >> +TODO: >> + - get bus width input instead of hardcoded bus width >> + >> + - make it easier to config different programming method for >> + other embedded targets, such as, different combination of gpio >> + or serial programming > > Odd formatting. > > And why is this last one a requirement to get this out of the staging > directory? > Next patch, v4, I updated the format. As I replied in other mail, my intention of staging this driver is to get feedback and reviewed by more people. So the last bullet item is not needed, and I've updated TODO file. >> +DONE: >> + - run checkpatch >> + - build tested > > No need to have this. > Removed. >> + >> +Please send any patches for this driver to Insop Song<insop.song@xxxxxxxxx> > > That's not the email address you sent this patch from. > Updated with my sign-off address >> +and Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>. And please CC linux-usb >> +<linux-usb@xxxxxxxxxxxxxxx> too. > > What does the linux-usb mailing list have to do with this driver? > Sorry, copy and past error from the TODO file that I referred. Updated to staging mailing list >> /* G100 specific bit swap and remmap (to gpio pins) for byte 0 */ >> @@ -225,7 +217,7 @@ static inline void byte1_out(unsigned char data) >> /* >> * TODO: >> * - configurable per device type for different I/O config >> - * so that this can be easily extended to G200 and more >> + * so that this can be easily extended other target devices > > Don't add incorrect lines if at all possible, others will just have to > go back and fix them up later. > > Oh, and please merge with the first patch, as asked for before. > Updated, and will send v4 in one patch. > thanks, > > greg k-h Thank you, ISS _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
