On Wed, Jan 8, 2014 at 10:16 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jan 08, 2014 at 10:00:15PM -0800, Insop Song wrote:
>> This module downloads Xilinx FPGA image using gpio pins
>>
>> DESIGN
>> ------
>> * load Xilinx FPGA bitstream format[1] image using kernel firmware
>> * framework,
>> request_firmware()
>
> Odd formatting of the changelog entry, care to fix this up?
>
I've updated and will send the 2nd patch.
>> * program the Xilinx FPGA using SelectMAP (parallel) mode [2]
>> * FPGA prgram is done by gpio based bit-banging, as an example
>> * platform independent file: gs_fpgaboot.c
>> * platform dependent file: io.c
>>
>> Signed-off-by: Insop Song <insop.song@xxxxxxxxxxxxx>
>> ---
>> drivers/staging/Kconfig | 2 +
>> drivers/staging/Makefile | 1 +
>> drivers/staging/gs_fpgaboot/Kconfig | 8 +
>> drivers/staging/gs_fpgaboot/Makefile | 4 +
>> drivers/staging/gs_fpgaboot/README | 60 ++++
>> drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 505 +++++++++++++++++++++++++++++
>> drivers/staging/gs_fpgaboot/gs_fpgaboot.h | 56 ++++
>> drivers/staging/gs_fpgaboot/io.c | 331 +++++++++++++++++++
>> drivers/staging/gs_fpgaboot/io.h | 90 +++++
>> 9 files changed, 1057 insertions(+)
>> create mode 100644 drivers/staging/gs_fpgaboot/Kconfig
>> create mode 100644 drivers/staging/gs_fpgaboot/Makefile
>> create mode 100644 drivers/staging/gs_fpgaboot/README
>> create mode 100644 drivers/staging/gs_fpgaboot/gs_fpgaboot.c
>> create mode 100644 drivers/staging/gs_fpgaboot/gs_fpgaboot.h
>> create mode 100644 drivers/staging/gs_fpgaboot/io.c
>> create mode 100644 drivers/staging/gs_fpgaboot/io.h
>
> Why is this driver going into the staging directory? We need a TODO
> file listing the issues that need to be taken care of in order to be
> able to move this out of the staging tree, can you please add that to
> your next version?
>
Embedded systems with FPGA requires FPGA programming after the system is booted.
I've written this driver to program FPGA after linux is booted.
TODO file is added to 2nd patch, which to be sent out shortly.
> Also be sure to add the responsible developer for the driver to the TODO
> file, see the other examples for the format of what is needed here.
>
>
>> --- /dev/null
>> +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
>> @@ -0,0 +1,505 @@
>> +/*
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>
> Do you really mean "any later version"? (sorry, I have to ask.)
>
Yes, sorry, I had to put.
>> +/* Assert and Deassert CCLK */
>> +void xl_shift_cclk(int count)
>> +{
>> + int i;
>> + for (i = 0; i < count; i++) {
>> + xl_cclk_b(1);
>> + xl_cclk_b(0);
>> + }
>> +}
>> +EXPORT_SYMBOL(xl_shift_cclk);
>
> You don't need to export symbols when they are only used in your own
> module.
>
All EXPORT_SYMBOL() are removed, thank you.
> thanks,
>
> greg k-h
Thank you,
ISS
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
