On 01/02/2014 02:44 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote:
Smatch shows the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv->sta_aid' 32 <= 32
This is a false positive in Smatch. Don't do work arounds for buggy
tools.
If you have the cross function database built on the latest version of
Smatch then I think it understands the code correctly and doesn't print
a warning.
When I analyzed the loop in question, I thought it resulted in a subscript of
[NUM_STA], but I now see that the largest one is [NUM_STA-1]. I will drop this
patch in the next round.
Thanks for the info regarding a new version of Smatch. I'll update now.
Larry
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
