On 01/02/2014 03:05 AM, Dan Carpenter wrote:
On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
--- a/drivers/staging/rtl8188eu/include/odm_interface.h
+++ b/drivers/staging/rtl8188eu/include/odm_interface.h
@@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
#define _cat(_name, _ic_type, _func) \
( \
- ((_ic_type) & ODM_IC_11N_SERIES) ? _func##_11N(_name) : \
+ (_ic_type) ? _func##_11N(_name) : \
_func##_11AC(_name) \
)
The original version of this function was more readable... I think
_ic_type is either zero or 16?
The original driver has some code that supports many different chips; however,
the present one only works for RTL8188E.
In the current driver, ODM_RTL8188E is always the only bit in odm_ic_type, thus
it is always 16. As a result (_ic_type & ODM_IC_11N_SERIES) is always equal to
_ic_type, which is why I simplified the macro.
If you really prefer the original version of the macro, I will leave it.
Larry
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
