On Wed, 18 Dec 2013, Dan Carpenter wrote:
Date: Wed, 18 Dec 2013 17:00:16 +0300
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
To: Gary Rookard <garyrookard@xxxxxxxxx>
Cc: devel@xxxxxxxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx,
lisa@xxxxxxxxxxxxxxx, josh@xxxxxxxxxxxxxxxx, nandu.hgowda@xxxxxxxxx
Subject: Re: [PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.
Gary emailed me privately that fixing my comments would be a problem.
1) Greg complained about your earlier patch where you moved the
comments from this:
/* comment */
code();
To this:
code(); /* comment */
Greg's complaint was not about that you were doing more than one thing
per patch it was that the comment style was better in the original.
2) A lot of newbies have problems with understanding where the line
between doing one thing per patch and doing two things in a patch is.
You are allowed to make *tiny* changes if they are closely related to
the central thrust of the patch.
So in this case the patch would be:
Staging: bcm: DDRInit: fix up some comments
I have removed the C99 comments. Some comments were bogus so instead of
fixing them, I just deleted them. I made a few minor grammar, spelling
and white space fixes as well.
It's still one thing which is "fixing comments".
regards,
dan carpenter
--
Understood, and trying to comply to that principal.
Thanks,
Gary Rookard
--
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
